code-423n4 / 2021-12-yetifinance-findings

0 stars 0 forks source link

Change function visibility from public to external #178

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

cccz

Vulnerability details

Impact

batchLiquidateTroves function in TroveManagerLiquidations.sol contract is never called from within contracts yet are declared public. Its visibility can be made external to save gas.

Proof of Concept

https://github.com/code-423n4/2021-12-nftx/blob/main/nftx-protocol-v2/contracts/solidity/NFTXStakingZap.sol#L300-L308

kingyetifinance commented 2 years ago

Duplicate #9

alcueca commented 2 years ago

Duplicate #270

alcueca commented 2 years ago

Duplicate of issue by the same warden