code-423n4 / 2021-12-yetifinance-findings

0 stars 0 forks source link

Assert is a waste of gas #194

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

certora

Vulnerability details

Impact

In CommuintyIssuance.sol line 84 you use assert instead of require. assert is a waste of gas since it will take all the gas that was sent to the transaction instead of stopping at the amount of gas spent until the failure.

Tools Used

Manual code review

Recommended Mitigation Steps

replace assert with require

kingyetifinance commented 2 years ago

@LilYeti: Duplicate #51 and that issue should level severity G

alcueca commented 2 years ago

Duplicate #157