code-423n4 / 2021-12-yetifinance-findings

0 stars 0 forks source link

Unused named returns #288

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

WatchPug

Vulnerability details

Unused named returns increase contract size and gas usage at deployment.

https://github.com/code-423n4/2021-11-unlock/blob/ec41eada1dd116bcccc5603ce342257584bec783/smart-contracts/contracts/Unlock.sol#L257-L260

https://github.com/code-423n4/2021-12-yetifinance/blob/5f5bf61209b722ba568623d8446111b1ea5cb61c/packages/contracts/contracts/AssetWrappers/WJLP/WJLP.sol#L246-L246

function _userUpdate(address _user, uint256 _amount, bool _isDeposit) private returns (uint pendingJoeSent) {

pendingJoeSent is unused.

kingyetifinance commented 2 years ago

@LilYeti : Duplicate #288

alcueca commented 2 years ago

It can't be a duplicate of itself

alcueca commented 2 years ago

Duplicate of #24