Interface improperly implemented

[code423n4]

Lines of code

---

34, 34, 34, 34, 30, 31, 32, 34, 35, 38, 39, 40, 41

Vulnerability details

---

The variables below have the same name as an interface function. Because the contract does not extend the interface, the compiler was unable to catch the fact that the variable is not public or external, and therefore all external references to the interface's function will revert. Change the visibility of the variables to public

File: contracts/Swapper/UniswapV3Swapper.sol

/// @audit ITapiocaOptionLiquidityProvision.yieldBox()
/// @audit IPenrose.yieldBox()
/// @audit IStrategy.yieldBox()
/// @audit IMarket.yieldBox()
34:      IYieldBox private immutable yieldBox;

File: contracts/glp/GlpStrategy.sol

/// @audit IGmxRewardRouterV2.gmx()
30:      IERC20 private immutable gmx;

/// @audit IGmxRewardRouterV2.esGmx()
31:      IERC20 private immutable esGmx;

/// @audit IGmxRewardRouterV2.weth()
32:      IERC20 private immutable weth;

/// @audit IGmxRewardRouterV2.feeGmxTracker()
34:      IGmxRewardTracker private immutable feeGmxTracker;

/// @audit IGmxRewardRouterV2.glpManager()
35:      IGlpManager private immutable glpManager;

/// @audit IGmxRewardRouterV2.glpVester()
38:      IGmxVester private immutable glpVester;

/// @audit IGmxRewardRouterV2.gmxVester()
39:      IGmxVester private immutable gmxVester;

/// @audit IGmxRewardRouterV2.stakedGlpTracker()
40:      IGmxRewardTracker private immutable stakedGlpTracker;

/// @audit IGmxRewardRouterV2.stakedGmxTracker()
41:      IGmxRewardTracker private immutable stakedGmxTracker;

Assessed type

---

other