search

code-423n4 / 2022-01-elasticswap-findings

1 stars 0 forks source link

Comment missing function parameter #114

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

sirhashalot

Vulnerability details

Impact

The Exchange.sol constructor has a natspec comment which is missing the _exchangeFactoryAddress function parameter. Issues with comments are low risk based on Code4rena risk categories.

Proof of Concept

Exchange.sol line 62 is missing a comment indicating the _exchangeFactoryAddress input parameter is required.

Recommended Mitigation Steps

Make sure natspec comments include all parameters and add one for the _exchangeFactoryAddress parameter.

GalloDaSballo commented 2 years ago

The finding is informational in nature, so I'm marking non-critical