code-423n4 / 2022-01-insure-findings

2 stars 0 forks source link

Unbounded iteration over all pools #313

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

Dravee

Vulnerability details

Impact

The transactions could fail if the array get too big and the transaction would consume more gas than the block limit. This will then result in a denial of service for the desired functionality and break core functionality.

Proof of Concept

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/IndexTemplate.sol#L655

Tools Used

VS Code

Recommended Mitigation Steps

Keep the array size small.

oishun1112 commented 2 years ago

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/IndexTemplate.sol#L593

There is max number of pools can be indexed

0xean commented 2 years ago

dupe of #352