code-423n4 / 2022-01-insure-findings

2 stars 0 forks source link

Gas Optimization: Use external keyword instead of public for some functions #319

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

gzeon

Vulnerability details

Impact

Use external keyword instead of public for some functions that are not used internally.

Proof of Concept

For example, the deposit function in PoolTemplate was never used internally. https://github.com/code-423n4/2022-01-insure/blob/19d1a7819fe7ce795e6d4814e7ddf8b8e1323df3/contracts/PoolTemplate.sol#L232

oishun1112 commented 2 years ago

https://github.com/code-423n4/2022-01-insure-findings/issues/7

0xean commented 2 years ago

dupe of #7