search

code-423n4 / 2022-01-livepeer-findings

0 stars 0 forks source link

Upgrade pragma to at least 0.8.4 #14

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

robee

Vulnerability details

    Using newer compiler versions and the optimizer gives gas optimizations
    and additional safety checks are available for free.

    The advantages of versions 0.8.* over <0.8.0 are:

    1. Safemath by default from 0.8.0 (can be more gas efficient than library based safemath.)
    2. Low level inliner : from 0.8.2, leads to cheaper runtime gas. Especially relevant when the contract has small functions. For example, OpenZeppelin libraries typically have a lot of small helper functions and if they are not inlined, they cost an additional 20 to 40 gas because of 2 extra jump instructions and additional stack operations needed for function calls.
    3. Optimizer improvements in packed structs: Before 0.8.3, storing packed structs, in some cases used an additional storage read operation. After EIP-2929, if the slot was already cold, this means unnecessary stack operations and extra deploy time costs. However, if the slot was already warm, this means additional cost of 100 gas alongside the same unnecessary stack operations and extra deploy time costs.
    4. Custom errors from 0.8.4, leads to cheaper deploy time cost and run time cost. Note: the run time cost is only relevant when the revert condition is met. In short, replace revert strings by custom errors.

    IController.sol
    IManager.sol
    Manager.sol
    BridgeMinter.sol
yondonfu commented 2 years ago

We are planning on updating the Solidity version of new contracts that will be deployed.

kautukkundan commented 2 years ago

fixed in https://github.com/livepeer/protocol/pull/533/commits/27f8b73ef492ec256209a52402a344e2a9d04bc1