code-423n4 / 2022-01-livepeer-findings

0 stars 0 forks source link

Incorrect erc20 interface #183

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

0v3rf10w

Vulnerability details

Impact

Incorrect return values for ERC20 functions results in failure when interacting with other contract , as the return value is missing.

Proof of Concept

ApproveLike (contracts/L1/gateway/L1Migrator.sol#67-69) has incorrect ERC20 function interface:ApproveLike.approve(address,uint256) (contracts/L1/gateway/L1Migrator.sol#68)

Interaction with contarcts fails due to incorrect erc20 implementation

Recommended Mitigation Steps

Set the appropriate return values and types for the defined ERC20 functions

yondonfu commented 2 years ago

Duplicate of https://github.com/code-423n4/2022-01-livepeer-findings/issues/93