code-423n4 / 2022-01-livepeer-findings

0 stars 0 forks source link

Lack of zero checks #212

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

0v3rf10w

Vulnerability details

Impact

Lack of zero checks at multiple places. I know it depends on viewpoint, mostly not needed as contracts are deployed through well defined scripts Happy to help anytime for further info if considered

Proof of Concept

L1Escrow.sol           
L1LPTGateway.sol       
L2LPTGateway.sol       
L1Migrator.sol         
L2Migrator.sol         
L1LPTDataCache.sol     
L2LPTDataCache.sol     
L1ArbitrumMessenger.sol
L2ArbitrumMessenger.sol
IL1LPTGateway.sol      
IL2LPTGateway.sol      
IMigrator.sol          
ControlledGateway.sol
BridgeMinter.sol

When declaring contracts addresses in above, add zero checks

Recommended Mitigation Steps

Add checks

yondonfu commented 2 years ago

Duplicate of https://github.com/code-423n4/2022-01-livepeer-findings/issues/4