search

code-423n4 / 2022-01-livepeer-findings

0 stars 0 forks source link

Don't assign default values #215

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

0x0x0x

Vulnerability details

Concept

When a variable is declared solidity assigns the default value. In case the contract assigns the value again, it costs extra gas.

Example:uint x = 0 costs more gas than uint x without having any different functionality.

Scope

./protocol/bonding/libraries/EarningsPool.sol:84:        uint256 delegatorFees = 0;
./protocol/bonding/libraries/EarningsPool.sol:85:        uint256 transcoderFees = 0;
./protocol/bonding/libraries/EarningsPool.sol:115:        uint256 delegatorRewards = 0;
./protocol/bonding/libraries/EarningsPool.sol:116:        uint256 transcoderRewards = 0;
./protocol/bonding/libraries/EarningsPool.sol:189:        uint256 transcoderFees = 0;
./protocol/bonding/libraries/EarningsPool.sol:190:        uint256 delegatorFees = 0;
./protocol/bonding/libraries/EarningsPool.sol:217:        uint256 transcoderRewards = 0;
./protocol/bonding/libraries/EarningsPool.sol:218:        uint256 delegatorRewards = 0;
./protocol/pm/mixins/MixinTicketBrokerCore.sol:121:        uint256 amountToTransfer = 0;
./protocol/token/Minter.sol:223:        uint256 currentBondingRate = 0;
./arbitrum-lpt-bridge/L1/gateway/L1Migrator.sol:471:        uint256 total = 0;
./protocol/zeppelin/MintableToken.sol:17:    bool public mintingFinished = false;
./protocol/zeppelin/Pausable.sol:13:    bool public paused = false;
yondonfu commented 2 years ago

Fixed by https://github.com/livepeer/protocol/pull/536/commits/0d9e53505f7ad643d78efa824b45b662d6efb320 https://github.com/livepeer/arbitrum-lpt-bridge/commit/86e07839c45793248c08fbb2cfec8ffd826a8b98