code-423n4 / 2022-01-livepeer-findings

0 stars 0 forks source link

Assign to 0 when _amount = l2SupplyFromL1 #221

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

Would be cheapier to have >= condition here to avoid extra calculation when _amount = l2SupplyFromL1:

  if (_amount > l2SupplyFromL1) {
      l2SupplyFromL1 = 0;
  } else {
      l2SupplyFromL1 -= _amount;
  }
yondonfu commented 2 years ago

Duplicate of https://github.com/code-423n4/2022-01-livepeer-findings/issues/137