Open code423n4 opened 2 years ago
samruna
https://github.com/code-423n4/2022-01-notional/blob/main/contracts/sNOTE.sol#L133
No upper limit check on swapFeePercentage. Although only owner can set this, human error can lead to higher percente swap, leading to excess swap and gas fee.
Severity should be Low Risk
Having a reasonable upper boundary would be a good improvement here, but I agree with the sponsor that this should be of low severity.
Handle
samruna
Vulnerability details
https://github.com/code-423n4/2022-01-notional/blob/main/contracts/sNOTE.sol#L133
No upper limit check on swapFeePercentage. Although only owner can set this, human error can lead to higher percente swap, leading to excess swap and gas fee.