code-423n4 / 2022-01-notional-findings

1 stars 3 forks source link

No upper limit check on swap fee Percentage #182

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

samruna

Vulnerability details

https://github.com/code-423n4/2022-01-notional/blob/main/contracts/sNOTE.sol#L133

No upper limit check on swapFeePercentage. Although only owner can set this, human error can lead to higher percente swap, leading to excess swap and gas fee.

jeffywu commented 2 years ago

Severity should be Low Risk

pauliax commented 2 years ago

Having a reasonable upper boundary would be a good improvement here, but I agree with the sponsor that this should be of low severity.