search

code-423n4 / 2022-01-notional-findings

1 stars 3 forks source link

Inclusive conditions #202

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

Either the error message or condition is not exactly correct, to cover the case when newBalance = reserveBalance:

  require(newBalance < reserveBalance, "cannot increase reserve balance");

These conditions should probably also be inclusive:

  coolDown.redeemWindowBegin < block.timestamp &&
  block.timestamp < coolDown.redeemWindowEnd
pauliax commented 2 years ago

I am grouping all issues related to inclusive conditions together and marking this issue as primary because it contains both cases, redeem window, and balances. No significant impact, so leaving it with a non-critical severity.