search

code-423n4 / 2022-01-openleverage-findings

0 stars 0 forks source link

Token Lock Contract Missing Sanity Check On The Time Interval #230

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

defsec

Vulnerability details

Impact

During the code review, It has been observed that startTime and endTime do not have necessity checks and that will cause to broken functionality on the contract. That will be resulted with re-deployment.

Proof of Concept

  1. Navigate to the following contract.

"https://github.com/code-423n4/2022-01-openleverage/blob/main/openleverage-contracts/contracts/OLETokenLock.sol#L35"

Tools Used

Code Review

Recommended Mitigation Steps

Consider initialize variables with comparision block.timestamp. Endtime should be bigger than starttime.

ColaM12 commented 2 years ago

Duplicate to #160