search

code-423n4 / 2022-01-openleverage-findings

0 stars 0 forks source link

Unused Re-entrancy Guard #232

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

defsec

Vulnerability details

Impact

In the Lpooldepositor contract, re-entrancy guard is defined but Its not used. Removing re-entrancy guard from the contract will provide gas optimization.

Proof of Concept

  1. Navigate to the following contract.

https://github.com/code-423n4/2022-01-openleverage/blob/main/openleverage-contracts/contracts/liquidity/LPoolDepositor.sol#L14

  1. Re-entrancy guard is not used.

Tools Used

Code Remove

Recommended Mitigation Steps

IT is recommended to delete un-used & redundant inheritance.

ColaM12 commented 2 years ago

Duplicate to #2

0xleastwood commented 2 years ago

I think this is actually a duplicate of #209 and not #2