search

code-423n4 / 2022-01-openleverage-findings

0 stars 0 forks source link

Missing zero checks #237

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

0v3rf10w

Vulnerability details

Impact

Missing zero checks at multiple places

Proof of Concept

Governable.setDAO(address).dao (contracts/DAO/Governable.sol#68) lacks a zero-check on :
                - DAO = dao (contracts/DAO/Governable.sol#70)
UniswapHelper.constructor(address,address)._limbo (contracts/UniswapHelper.sol#80) lacks a zero-check on :
                - limbo = _limbo (contracts/UniswapHelper.sol#81)
UniswapHelper.configure(address,address,address,address,uint256,uint256,uint8,uint8)._limbo (contracts/UniswapHelper.sol#115) lacks a zero-check on :
                - limbo = _limbo (contracts/UniswapHelper.sol#124)

missing events :

UniswapHelper.configure(address,address,address,address,uint256,uint256,uint8,uint8) (contracts/UniswapHelper.sol#114-135) should emit an event for: 
        - limbo = _limbo (contracts/UniswapHelper.sol#124)

Recommended Mitigation Steps

Add respective checks

itsmetechjay commented 2 years ago

Withdrawn by warden. They submitted to the wrong contest.