search

code-423n4 / 2022-01-openleverage-findings

0 stars 0 forks source link

Comment missing function parameter #248

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

sirhashalot

Vulnerability details

Impact

The OLEToken.sol contract has some natspec comments that mention one input parameter but fail to mention or describe the other input parameter(s) of the function. Issues with comments are low risk based on Code4rena risk categories.

Proof of Concept

The functions missing a comment mentioning input parameters include:

Recommended Mitigation Steps

Make sure natspec comments include all function input parameters.

ColaM12 commented 2 years ago

I believe these params are self explaining.

0xleastwood commented 2 years ago

Agree with sponsor, it seems trivial to work out what they mean.