code-423n4 / 2022-01-openleverage-findings

0 stars 0 forks source link

OpenLevV1.sol comment missing function parameter #260

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

sirhashalot

Vulnerability details

Impact

The OpenLevV1.sol contract has a natspec comment that fails to mention one of the input parameters despite describing the other input parameter(s) of the function. Issues with comments are low risk based on Code4rena risk categories.

Proof of Concept

Several functions are missing a comment mentioning the uint16 "marketId" input parameter, including but not limited to:

Recommended Mitigation Steps

Make sure natspec comments include all function input parameters.

ColaM12 commented 2 years ago

@param marketId marketId

0xleastwood commented 2 years ago

Again, pretty self-explanatory.