search

code-423n4 / 2022-01-openleverage-findings

0 stars 0 forks source link

Unsafe Cast #40

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

mics

Vulnerability details

use openzeppilin's safeCast in:

    ControllerV1.sol, (L#190): unsafe cast from uint256 to uint64 of the variable blockTime
    ControllerV1.sol, (L#192): unsafe cast from uint256 to uint64 of the variable blockTime
ColaM12 commented 2 years ago

For blockTime it is unlikely to overflow.

0xleastwood commented 2 years ago

The warden has not provided any reason as to how this issue might occur. Block time can easily fit within uint64, hence there is no reason to expect an overflow.