code-423n4 / 2022-01-sandclock-findings

0 stars 0 forks source link

fees amounts are wrong #120

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

danb

Vulnerability details

https://github.com/code-423n4/2022-01-sandclock/blob/main/sandclock/contracts/strategy/BaseStrategy.sol#L184

original amount is wrong. if there is more than one deposit to aust, or someone accidently transfers aust to the contract, it would mess up original amount and the fees amounts will be wrong.

naps62 commented 2 years ago

It is not clear what value exactly is being pointed at. The linked line does not refer to fee amounts. This lacks a clear description and reproduction steps

dmvt commented 2 years ago

Agree with sponsor. This is very unclear and does not deal with fees at all. Invalid.