search

code-423n4 / 2022-01-sandclock-findings

0 stars 0 forks source link

Open TODOs in Codebase #174

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

There are TODOs left in the code. While this does not cause any direct issue, it indicates a bad smell and uncertainty and makes it harder for an auditor to make assumptions.

  // TODO: emit the groupId
  // TODO no invested amount yet
  // TODO exclude sponsored assets
  // TODO Make names dynamic

Recommended Mitigation Steps

Consider fixing TODOs or removing distracting comments.

naps62 commented 2 years ago

duplicate of #171 (and probably others)

dmvt commented 2 years ago

duplicate of #96