search

code-423n4 / 2022-01-sandclock-findings

0 stars 0 forks source link

Unclear require statement #180

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

Dravee

Vulnerability details

Impact

Revert string in require statement seems to be wrong (ie issue with comments)

Proof of Concept

Here, it says "Vault: token id is not a withdraw": https://github.com/code-423n4/2022-01-sandclock/blob/main/sandclock/contracts/Vault.sol#L540

My guess is that it should be "Vault: token id is not a deposit"

Tools Used

VS Code

Recommended Mitigation Steps

Correct the revert string

naps62 commented 2 years ago

Isn't this non-critical?

dmvt commented 2 years ago

Issues with comments are low risk.

1 — Low: Low: Assets are not at risk. State handling, function incorrect as to spec, issues with comments.