Closed code423n4 closed 2 years ago
Dravee
Revert string in require statement seems to be wrong (ie issue with comments)
Here, it says "Vault: token id is not a withdraw": https://github.com/code-423n4/2022-01-sandclock/blob/main/sandclock/contracts/Vault.sol#L540
My guess is that it should be "Vault: token id is not a deposit"
VS Code
Correct the revert string
Isn't this non-critical?
Issues with comments are low risk.
1 — Low: Low: Assets are not at risk. State handling, function incorrect as to spec, issues with comments.
Handle
Dravee
Vulnerability details
Impact
Revert string in require statement seems to be wrong (ie issue with comments)
Proof of Concept
Here, it says "Vault: token id is not a withdraw": https://github.com/code-423n4/2022-01-sandclock/blob/main/sandclock/contracts/Vault.sol#L540
My guess is that it should be "Vault: token id is not a deposit"
Tools Used
VS Code
Recommended Mitigation Steps
Correct the revert string