code-423n4 / 2022-01-sandclock-findings

0 stars 0 forks source link

No input check : claim.pct = 0 #187

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pedroais

Vulnerability details

Impact

The claiming percentage can be set to 0 for a claimer https://github.com/code-423n4/2022-01-sandclock/blob/a90ad3824955327597be00bb0bd183a9c228a4fb/sandclock/contracts/Vault.sol#L420

Recommended Mitigation Steps

Require claim.ptc != 0

naps62 commented 2 years ago

Fixed in https://github.com/sandclock-org/solidity-contracts/pull/85