code-423n4 / 2022-01-sherlock-findings

0 stars 0 forks source link

Redundant check in `SherBuy.execute` #189

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

ych18

Vulnerability details

SherBuy.execute uses the function viewCapitalRequirements which checks whether the liquidity event is active with if (active() == false) revert InvalidState();. Then SherBuy.execute uses SherClaim.add which also checks for the same thing with the active function in L62: