code-423n4 / 2022-01-sherlock-findings

0 stars 0 forks source link

inheriting contracts don't have to import dependencies again. #207

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

haku

Vulnerability details

Impact

When a contract imports and implements an interface or another contracts, it doesn't need to import the libraries that were already imported there.

Removing these imports will save gas.

Proof of Concept

ISherlock.sol imports IERC721.sol. So Sherlock.sol don't have to import IERC721.sol.

Tools Used

VS Code

Recommended Mitigation Steps

remove important statement.