search

code-423n4 / 2022-01-sherlock-findings

0 stars 0 forks source link

constant value should be private or internal. #208

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

haku

Vulnerability details

Impact

constant value should be private or internal. it can save gas.

Proof of Concept

https://github.com/code-423n4/2022-01-sherlock/blob/c763f10c4b5fe2127677d6c25b83adcf3bcec212/contracts/Sherlock.sol#L25-L34

Tools Used

VS Code

Recommended Mitigation Steps

change public to private/internal.

jack-the-pug commented 2 years ago

Dup #116