code-423n4 / 2022-01-sherlock-findings

0 stars 0 forks source link

Replacing condition == false for !condition can saves gas. #209

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

haku

Vulnerability details

Impact

Replacing condition == false for !condition can saves gas.

Proof of Concept

https://github.com/code-423n4/2022-01-sherlock/blob/c763f10c4b5fe2127677d6c25b83adcf3bcec212/contracts/SherBuy.sol#L89 https://github.com/code-423n4/2022-01-sherlock/blob/c763f10c4b5fe2127677d6c25b83adcf3bcec212/contracts/SherBuy.sol#L126

Tools Used

VS Code

Recommended Mitigation Steps

condition == false for !condition

jack-the-pug commented 2 years ago

Dup #132