The stakingPeriods() is called on _sherlockPosition to validate that PERIOD is active. Hence, checking that _sherlockPosition is non-zero is redundant.
Recommended Mitigation Steps
Remove the check if (address(_sherlockPosition) == address(0)) revert ZeroArgument();
jack-the-pug
commented
2 years ago
Handle
GreyArt
Vulnerability details
Impact
The
stakingPeriods()is called on_sherlockPositionto validate thatPERIODis active. Hence, checking that_sherlockPositionis non-zero is redundant.Recommended Mitigation Steps
Remove the check
if (address(_sherlockPosition) == address(0)) revert ZeroArgument();