The priceProposed() and priceDisputed() callback functions have the following comment:
// @note reentrancy is allowed for this call
It isn’t that re-entrancy is allowed, but that it doesn’t have re-entrancy protection because it is chained in the interactions with the UMA OO contract when claims are escalated. The current comment may mislead people into thinking that re-entrancy can be performed when there is in fact reentrancy protection in the starting function escalate().
Recommended Mitigation Steps
Update the comment to provide better clarity.
// @note does not have reentrancy protection because it will be called by the OO contract
// when escalate() is invoked, which is non-reentrant
Handle
GreyArt
Vulnerability details
Impact
The
priceProposed()
andpriceDisputed()
callback functions have the following comment:// @note reentrancy is allowed for this call
It isn’t that re-entrancy is allowed, but that it doesn’t have re-entrancy protection because it is chained in the interactions with the UMA OO contract when claims are escalated. The current comment may mislead people into thinking that re-entrancy can be performed when there is in fact reentrancy protection in the starting function
escalate()
.Recommended Mitigation Steps
Update the comment to provide better clarity.