The SherlockClaimManager refers to the UMA Halt Operator as UMAHO, but ISherlockClaimManager refers to it as UHMA and UHO. Sticking to one acronym will provider better clarity.
Recommended Mitigation Steps
Change UMHA and UHO to UMAHO.
// UMHA can halt claim if state is UmaApproved → // UMAHO can halt claim if state is UmaApproved
// So SPCC and UHO are hardcoded (UHO can be renounced) → // So SPCC and UMAHO are hardcoded (UMAHO can be renounced)
Handle
GreyArt
Vulnerability details
Impact
The
SherlockClaimManagerrefers to the UMA Halt Operator asUMAHO, butISherlockClaimManagerrefers to it asUHMAandUHO. Sticking to one acronym will provider better clarity.Recommended Mitigation Steps
Change
UMHAandUHOtoUMAHO.// UMHA can halt claim if state is UmaApproved→// UMAHO can halt claim if state is UmaApproved// So SPCC and UHO are hardcoded (UHO can be renounced)→// So SPCC and UMAHO are hardcoded (UMAHO can be renounced)