code-423n4 / 2022-01-sherlock-findings

0 stars 0 forks source link

Check if amount is not zero to save gas #240

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

robee

Vulnerability details

The following functions could skip other steps if the amount is 0. (A similar issue: https://github.com/code-423n4/2021-10-badgerdao-findings/issues/82)

    SherDistributionManager.sol, pullReward
    SherlockProtocolManager.sol, protocolAdd
    SherBuy.sol, execute
    SherlockClaimManager.sol, escalate