search

code-423n4 / 2022-01-sherlock-findings

0 stars 0 forks source link

cheaper to use !active() #254

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

Fitraldys

Vulnerability details

Impact

in line https://github.com/code-423n4/2022-01-sherlock/blob/main/contracts/SherClaim.sol#L79 is cheaper to use !active() than using active() == false.

Proof of Concept

https://github.com/code-423n4/2022-01-sherlock/blob/main/contracts/SherClaim.sol#L79

jack-the-pug commented 2 years ago

Dup #132