Open code423n4 opened 2 years ago
wuwe1
https://github.com/code-423n4/2022-01-sherlock/blob/main/contracts/Sherlock.sol#L28
https://github.com/code-423n4/2022-01-sherlock/blob/main/contracts/Sherlock.sol#L621
The implementation of _calcSharesForArbRestake doesn’t consistent with documentation.
_calcSharesForArbRestake
The "reward" for an arbitrager increases slowly over the course of 2 weeks
According the document https://docs.sherlock.xyz/stakers/lockup-period#unstaking, the ARB_RESTAKE_GROWTH_TIME should be two weeks.
ARB_RESTAKE_GROWTH_TIME
Modifier documentation or implementation.
0 non critical
Evert0x
commented
2 years ago Evert0x
commented
2 years ago
Handle
wuwe1
Vulnerability details
Proof of Concept
https://github.com/code-423n4/2022-01-sherlock/blob/main/contracts/Sherlock.sol#L28
https://github.com/code-423n4/2022-01-sherlock/blob/main/contracts/Sherlock.sol#L621
The implementation of
_calcSharesForArbRestakedoesn’t consistent with documentation.According the document https://docs.sherlock.xyz/stakers/lockup-period#unstaking, the
ARB_RESTAKE_GROWTH_TIMEshould be two weeks.Recommended Mitigation Steps
Modifier documentation or implementation.