code-423n4 / 2022-01-timeswap-findings

2 stars 0 forks source link

immutable variables `fee` and `protocolFee` are unbounded #128

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

Dravee

Vulnerability details

In TimeswapFactory and TimeswapPair: immutable variables fee and protocolFee aren't bounded. It could get troublesome for users in the case of malicious/faulty governor contract.

Recommended Mitigation Steps

Set a max fee and a max protocolFee

amateur-dev commented 2 years ago

Similar issue reported over here #33; hence closing this issue