search

code-423n4 / 2022-01-timeswap-findings

2 stars 0 forks source link

Inline unnecessary internal function can save gas #163

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

WatchPug

Vulnerability details

checkProportional() is a rather simple one line function, making it inline instead of an internal function call can make the code simpler and save some gas.

https://github.com/code-423n4/2022-01-timeswap/blob/bf50d2a8bb93a5571f35f96bd74af54d9c92a210/Timeswap/Timeswap-V1-Core/contracts/TimeswapPair.sol#L359-L368

for (uint256 i; i < ids.length; i++) {
    Due storage due = dues[ids[i]];
    require(due.startBlock != BlockNumber.get(), 'E207');
    if (owner != msg.sender) require(collateralsOut[i] == 0, 'E213');
    PayMath.checkProportional(assetsIn[i], collateralsOut[i], due);
    due.debt -= assetsIn[i];
    due.collateral -= collateralsOut[i];
    assetIn += assetsIn[i];
    collateralOut += collateralsOut[i];
}

https://github.com/code-423n4/2022-01-timeswap/blob/bf50d2a8bb93a5571f35f96bd74af54d9c92a210/Timeswap/Timeswap-V1-Core/contracts/libraries/PayMath.sol#L7-L14

function checkProportional(
    uint112 assetIn,
    uint112 collateralOut,
    IPair.Due memory due
) internal pure {
    require(uint256(assetIn) * due.collateral >= uint256(collateralOut) * due.debt, 'E303');
}
}

Can be changed to:

for (uint256 i; i < ids.length; i++) {
    Due storage due = dues[ids[i]];
    require(due.startBlock != BlockNumber.get(), 'E207');
    if (owner != msg.sender) require(collateralsOut[i] == 0, 'E213');
    require(uint256(assetIn[i]) * due.collateral >= uint256(collateralOut[i]) * due.debt, 'E303');
    due.debt -= assetsIn[i];
    due.collateral -= collateralsOut[i];
    assetIn += assetsIn[i];
    collateralOut += collateralsOut[i];
}
Mathepreneur commented 2 years ago

https://github.com/Timeswap-Labs/Timeswap-V1-Core/pull/88