code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

Missing Zero Addresss Check #189

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

Funen

Vulnerability details

Impact

The user's that had been deploy the contract will got zero address

Proof of Concept

https://github.com/code-423n4/2022-01-trader-joe/blob/main/contracts/RocketJoeFactory.sol#L53-L61 This contract was using address to check that Addresses can't be zero address

E.g. : https://github.com/code-423n4/2022-01-trader-joe/blob/main/contracts/RocketJoeStaking.sol this wasnt check that addresses not zero address

Tools Used

Manual Review

cryptofish7 commented 2 years ago

Duplicate of #266