code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

`IssuingTokenDeposited` event not emitted #203

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

cmichel

Vulnerability details

The IssuingTokenDeposited event in LaunchEvent is not used. Unused code can hint at programming or architectural errors.

Recommendation

Use it or remove it.

cryptofish7 commented 2 years ago

Duplicate of #148

dmvt commented 2 years ago

Event issues are non-critical

0 — Non-critical (0): vulns have a risk of 0 and are considered “Non-critical” whenCode style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas-optimisations