Closed code423n4 closed 2 years ago
Meta0xNull
require(msg.sender != issuer, "LaunchEvent: issuer cannot participate");
depositAVAX() Require msg.sender != issuer is Waste of Gas because issuer can call depositAVAX() by using different wallet address.
https://github.com/code-423n4/2022-01-trader-joe/blob/main/contracts/LaunchEvent.sol#L312
Manual Review
Remove Line 312 to save participants gas fee.
It doesn’t matter if issuer enters with a different wallet, it’s to make sure he shouldn’t receive LP / incentives
Agree with sponsor. Sacrificing features or guards to save gas is not reasonable.
Handle
Meta0xNull
Vulnerability details
Impact
depositAVAX() Require msg.sender != issuer is Waste of Gas because issuer can call depositAVAX() by using different wallet address.
Proof of Concept
https://github.com/code-423n4/2022-01-trader-joe/blob/main/contracts/LaunchEvent.sol#L312
Tools Used
Manual Review
Recommended Mitigation Steps
Remove Line 312 to save participants gas fee.