search

code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

Saving more gas by using `immutable phase` #229

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

Funen

Vulnerability details

Proof of Concept

https://github.com/code-423n4/2022-01-trader-joe/blob/main/contracts/LaunchEvent.sol#L48-L50 the Phase called from RJoeFactory.sol , so immutable can saving more gas

Tools Used

Manual Review

Recommended Mitigation Steps

uint256 public PHASE_ONE_DURATION ;  
uint256 public PHASE_ONE_NO_FEE_DURATION; 
uint256 public PHASE_TWO_DURATION;

changed into 

uint256 public immutable PHASE_ONE_DURATION; 
uint256 public immutable PHASE_ONE_NO_FEE_DURATION; 
uint256 public immutable PHASE_TWO_DURATION;