Open code423n4 opened 2 years ago
Funen
https://github.com/code-423n4/2022-01-trader-joe/blob/main/contracts/LaunchEvent.sol#L48-L50 the Phase called from RJoeFactory.sol , so immutable can saving more gas
Phase
RJoeFactory.sol
Manual Review
uint256 public PHASE_ONE_DURATION ; uint256 public PHASE_ONE_NO_FEE_DURATION; uint256 public PHASE_TWO_DURATION;
changed into
uint256 public immutable PHASE_ONE_DURATION; uint256 public immutable PHASE_ONE_NO_FEE_DURATION; uint256 public immutable PHASE_TWO_DURATION;
Handle
Funen
Vulnerability details
Proof of Concept
https://github.com/code-423n4/2022-01-trader-joe/blob/main/contracts/LaunchEvent.sol#L48-L50 the
Phase
called fromRJoeFactory.sol
, so immutable can saving more gasTools Used
Manual Review
Recommended Mitigation Steps
changed into