Open code423n4 opened 2 years ago
WatchPug
https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/LaunchEvent.sol#L19-L19
contract LaunchEvent is Ownable {
The LaunchEvent.sol contract never utilized onlyOwner / owner() or any other features provided by the Ownable library.
LaunchEvent.sol
onlyOwner
owner()
Ownable
Therefore, is Ownable can be removed.
is Ownable
Should be 0 severity.
Fix; https://github.com/traderjoe-xyz/rocket-joe/commit/989bb6ccf0b44b8f7f120a5f893b701118c1d9a6
Leaving the unnecessary contract out will save gas depending on how you deploy.
Handle
WatchPug
Vulnerability details
https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/LaunchEvent.sol#L19-L19
The
LaunchEvent.sol
contract never utilizedonlyOwner
/owner()
or any other features provided by theOwnable
library.Therefore,
is Ownable
can be removed.