Closed code423n4 closed 2 years ago
saian
transferFrom might return false in some implementation that will go unchecked, use a require() or openzeppelin's safeTransferFrom
https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/RocketJoeFactory.sol#L133
Manual Analysis
Use a require statement to check return value or use safeTransferFrom
Duplicate of #232
duplicate of #198
Handle
saian
Vulnerability details
Impact
transferFrom might return false in some implementation that will go unchecked, use a require() or openzeppelin's safeTransferFrom
Proof of Concept
https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/RocketJoeFactory.sol#L133
Tools Used
Manual Analysis
Recommended Mitigation Steps
Use a require statement to check return value or use safeTransferFrom