Closed code423n4 closed 2 years ago
Adding further context from warden Czar102, sent via DM:
Also, a crucial modification is not to revert on call failure. Whether it is because of not enough gas in the call context or a deliberate revertion.
It's assumed that the owner is well-behaved
I can't come up with a reason that the owner of a launch would DOS their own launch. If they were a bad actor it would be much more lucrative to see the launch through and then rug it. Invalid.
Handle
Czar102
Vulnerability details
Impact
The owner of can DoS the
withdrawAVAX()
function by settingpenaltyCollector
inRocketJoeFactory
to a contract that triggers an infinite loop, or uses gas to perform own operations (can store it to get refunds like in gas token). This way, an owner can use withdrawing wallets to pay for their transactions or DoS the withdrawal function.Proof of Concept
Tools Used
Manual analysis
Recommended Mitigation Steps
Add gas limit on the call to
penaltyCollector
.