search

code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

Error never thrown #278

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

Czar102

Vulnerability details

Impact

_atPhase internal function of LaunchEvent contains a revert statement that will never be triggered as the argument of the function is always one of the correct states, based on all uses.

Proof of Concept

        } else {
            revert("LaunchEvent: unknown state");
        }

Tools Used

Manual analysis

Recommended Mitigation Steps

Delete the else statement as it is redundant.