code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

Repeated storage access #300

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

Avoid repeated storage access:

  require(
      user.balance > 0,
      "LaunchEvent: expected user to have non-zero balance to perform emergency withdraw"
  );
  uint256 balance = user.balance;

Proposed improvement:

  uint256 balance = user.balance;
    require(
      balance > 0,
      "LaunchEvent: expected user to have non-zero balance to perform emergency withdraw"
  );