code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

PRECISION is constant #301

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

PRECISION does not change, thus it can be assigned initially and marked as a constant to reduce gas costs:

  uint256 private PRECISION; // now
  uint256 private constant PRECISION = 1e18; // proposed
cryptofish7 commented 2 years ago

Duplicate of #239

dmvt commented 2 years ago

Per sponsor, this is invalid because the contract in question is proxied.