code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

router can be set to address(0) #305

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

gzeon

Vulnerability details

Impact

https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/RocketJoeFactory.sol#L178

    function setRouter(address _router) external override onlyOwner {
        router = _router;
        emit SetRouter(_router);
    }

would cause this to revert https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/LaunchEvent.sol#L411

        (, , lpSupply) = router.addLiquidity(

cryptofish7 commented 2 years ago

Duplicate of #263