search

code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

factory can be set to address(0) #306

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

gzeon

Vulnerability details

Impact

https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/RocketJoeFactory.sol#L187

    function setFactory(address _factory) external override onlyOwner {
        factory = _factory;
        emit SetFactory(_factory);
    }

would cause this to revert https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/LaunchEvent.sol#L385

                IJoePair(
                    IJoeFactory(factory).getPair(wavaxAddress, tokenAddress)
                ).totalSupply() ==
cryptofish7 commented 2 years ago

Duplicate of #263