search

code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

Event Is Defined But Not Used On The Contract (IssuingTokenDeposited) #307

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

defsec

Vulnerability details

In the LaunchEvent contract, IssuingTokenDeposited event is defined but It's not used. If It's not necessary and not handled on the user interface consider to delete from the contract.

    event IssuingTokenDeposited(address indexed token, uint256 amount);

Proof of Concept

  1. Navigate to the contract.
https://github.com/code-423n4/2022-01-trader-joe/blob/main/contracts/LaunchEvent.sol#L124
  1. Event is not used.

Tools Used

Code Review

Recommended Mitigation Steps

Consider to use event or delete it for the gas optimization.

cryptofish7 commented 2 years ago

Duplicate of #148

dmvt commented 2 years ago

Event issues are non-critical

0 — Non-critical (0): vulns have a risk of 0 and are considered “Non-critical” whenCode style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas-optimisations