code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

Variables could be inmutable #311

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pedroais

Vulnerability details

Impact

gas saving

Proof of Concept

Variables that are settled in the initializer function and never changed could be immutable to save gas https://github.com/code-423n4/2022-01-trader-joe/blob/a1579f6453bc4bf9fb0db9c627beaa41135438ed/contracts/LaunchEvent.sol#L56

cryptofish7 commented 2 years ago

We are using initialize method, immutable variables can only be set in constructor.